Add rel='noopener' to all links opening in a new window #10012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a start. I'm not sure if I found all the relevant bits, and would be happy for pointers (or corrections). |
|
Do we have to care about such old browsers? Such users should not expect security from others if they are using outdated software themselves. ps. your changes collide with rel=noreferrer in a few places. |
|
In principle we don't have to, but it's not much work and in other regards we care to support old versions, e.g. PHP v8.1, which is out of active support since Nov 2023. So why not just do it? |
pabzm
force-pushed
the
noopener
branch
4 times, most recently
from
c257f28 to
bc78feb
Compare
|
I removed the @alecpl Please have another look. |
Browsers younger than ~5 years don't need this, but older browsers might cause problems. Code style change as demanded by eslint Remove accidentally added `id` attribute Fix test as it was intended
|
I'm merging this now on my own because it's waiting for quite a while, even though it's just a small change, and doesn't hurt but helps with older browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers younger than ~5 years don't need this, but older browsers might cause problems.